Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2298783002: Resolve percentage in <use> against the instance's viewport element (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resolve percentage in <use> against the instance's viewport element In LayoutSVGTransformableContainer::calculateLocalTransform, 'x' and 'y' were resolved against the original (corresponding) element. For a <use> nested within a <symbol>, this would mean that when were going to look up the viewport element, we'd return the outer <symbol> element and thus fail to get a viewport. Use the instance element to setup the SVGLengthContext instead. BUG=642524 Committed: https://crrev.com/b34ff6fe2d5842a63e2c66f68f050f0cf9163010 Cr-Commit-Position: refs/heads/master@{#415910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/use-nested-symbol-viewport.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/use-nested-symbol-viewport-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-08-31 17:21:17 UTC) #4
pdr.
LGTM
4 years, 3 months ago (2016-09-01 05:37:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298783002/1
4 years, 3 months ago (2016-09-01 08:24:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 08:29:09 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 08:31:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b34ff6fe2d5842a63e2c66f68f050f0cf9163010
Cr-Commit-Position: refs/heads/master@{#415910}

Powered by Google App Engine
This is Rietveld 408576698