Issue 2298773003: Fix an off-by-one error in vmservice expression evaluation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2298773003: Fix an off-by-one error in vmservice expression evaluation. (Closed)

Created:
4 years, 3 months ago by turnidge

Modified:
4 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

turnidge

Matthias, This should fix the following bug which you reported some time ago: https://github.com/dart-lang/sdk/issues/25973 Todd

4 years, 3 months ago (2016-08-31 23:57:00 UTC) #2

hausner

LGTM The fix is so simple when you know what you're doing :)

4 years, 3 months ago (2016-09-01 03:05:19 UTC) #3

turnidge

4 years, 3 months ago (2016-09-06 19:50:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ec6d9efc3808fdf60e9af68be3c9779be5608db7 (presubmit successful).