Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2298753003: Check first page number in CPDF_HintTables::ReadPageHintTable(). (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Check first page number in CPDF_HintTables::ReadPageHintTable(). BUG=642655 Committed: https://pdfium.googlesource.com/pdfium/+/73e9c31d7eb8ecc59086c29e8e3e5bb4062b4424

Patch Set 1 #

Total comments: 2

Patch Set 2 : more #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 1 4 chunks +11 lines, -3 lines 3 comments Download

Messages

Total messages: 14 (7 generated)
Lei Zhang
4 years, 3 months ago (2016-08-31 21:55:55 UTC) #2
Tom Sepez
https://codereview.chromium.org/2298753003/diff/1/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right): https://codereview.chromium.org/2298753003/diff/1/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp#newcode168 core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:168: if (nFirstPageNum < 0) Is there a reason this ...
4 years, 3 months ago (2016-08-31 21:58:10 UTC) #3
Lei Zhang
I added more checks in all the places that use the first page number. https://codereview.chromium.org/2298753003/diff/1/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp ...
4 years, 3 months ago (2016-08-31 23:45:51 UTC) #6
Tom Sepez
lgtm https://codereview.chromium.org/2298753003/diff/20001/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right): https://codereview.chromium.org/2298753003/diff/20001/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp#newcode357 core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:357: bool CPDF_HintTables::GetPagePos(int index, nit: can index at least ...
4 years, 3 months ago (2016-09-01 00:06:51 UTC) #9
Lei Zhang
https://codereview.chromium.org/2298753003/diff/20001/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right): https://codereview.chromium.org/2298753003/diff/20001/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp#newcode357 core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:357: bool CPDF_HintTables::GetPagePos(int index, On 2016/09/01 00:06:51, Tom Sepez wrote: ...
4 years, 3 months ago (2016-09-01 00:11:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298753003/20001
4 years, 3 months ago (2016-09-01 00:11:51 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 00:12:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/73e9c31d7eb8ecc59086c29e8e3e5bb4062b...

Powered by Google App Engine
This is Rietveld 408576698