Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp

Issue 2298753002: binding: Updates ExceptionStatePlaceholder according to ExceptionState. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
index c510a12875f17262fa0efb4d2a5f03de8a1b8a52..8b20f57427d0309eb76e2fcb1b5abdab6aae3fb5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
@@ -35,7 +35,7 @@ namespace blink {
#if ENABLE(ASSERT)
NoExceptionStateAssertionChecker::NoExceptionStateAssertionChecker(const char* file, int line)
- : ExceptionState(ExceptionState::UnknownContext, 0, 0, v8::Local<v8::Object>(), 0)
+ : ExceptionState(nullptr, ExceptionState::UnknownContext, nullptr, nullptr)
, m_file(file)
, m_line(line) { }
@@ -44,9 +44,9 @@ void NoExceptionStateAssertionChecker::throwDOMException(const ExceptionCode&, c
DCHECK_AT(false, m_file, m_line) << "DOMExeption should not be thrown.";
}
-void NoExceptionStateAssertionChecker::throwTypeError(const String&)
+void NoExceptionStateAssertionChecker::throwRangeError(const String& message)
{
- DCHECK_AT(false, m_file, m_line) << "TypeError should not be thrown.";
+ DCHECK_AT(false, m_file, m_line) << "RangeError should not be thrown.";
}
void NoExceptionStateAssertionChecker::throwSecurityError(const String&, const String&)
@@ -54,6 +54,16 @@ void NoExceptionStateAssertionChecker::throwSecurityError(const String&, const S
DCHECK_AT(false, m_file, m_line) << "SecurityError should not be thrown.";
}
+void NoExceptionStateAssertionChecker::throwTypeError(const String&)
+{
+ DCHECK_AT(false, m_file, m_line) << "TypeError should not be thrown.";
+}
+
+void NoExceptionStateAssertionChecker::rethrowV8Exception(v8::Local<v8::Value>)
+{
+ DCHECK_AT(false, m_file, m_line) << "An exception should not be rethrown.";
+}
+
#endif
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698