Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2298753002: binding: Updates ExceptionStatePlaceholder according to ExceptionState. (Closed)

Created:
4 years, 3 months ago by Yuki
Modified:
4 years, 3 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Updates ExceptionStatePlaceholder according to ExceptionState. ExceptionStatePlaceholer was out-dated. This CL updates it according to the latest ExceptionState, adding throwRangeError and rethrowV8Exception. BUG= Committed: https://crrev.com/6a664cdc26940eb90d92f11eedce7be6e0baa09c Cr-Commit-Position: refs/heads/master@{#415659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h View 2 chunks +17 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yuki
Could you review this CL?
4 years, 3 months ago (2016-08-31 13:04:58 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-08-31 14:13:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298753002/1
4 years, 3 months ago (2016-08-31 14:17:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 16:49:13 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:52:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a664cdc26940eb90d92f11eedce7be6e0baa09c
Cr-Commit-Position: refs/heads/master@{#415659}

Powered by Google App Engine
This is Rietveld 408576698