Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2298743002: Make the condition for when this is predeclared easier to understand. (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make the condition for when this is predeclared easier to understand. Just always predeclare it R=marja@chromium.org,verwaest@chromium.org BUG=v8:5215 Committed: https://crrev.com/60a783c246ba8c46b35dd38e19584d2135b4a321 Cr-Commit-Position: refs/heads/master@{#39048}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M src/ast/scopes.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.cc View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M src/parsing/parser-base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-31 11:31:54 UTC) #1
marja
lgtm https://codereview.chromium.org/2298743002/diff/20001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2298743002/diff/20001/src/ast/scopes.cc#newcode139 src/ast/scopes.cc:139: Nit: how about DCHECK_EQ(scope_type, SCRIPT_SCOPE) here, just for ...
4 years, 3 months ago (2016-08-31 12:27:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298743002/40001
4 years, 3 months ago (2016-08-31 12:31:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 13:33:28 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 13:34:01 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60a783c246ba8c46b35dd38e19584d2135b4a321
Cr-Commit-Position: refs/heads/master@{#39048}

Powered by Google App Engine
This is Rietveld 408576698