Removing Nope button in Update password prompt according to mocks.

Removing Nope button in Update password prompt according to mocks.

BUG=564674
Committed: https://crrev.com/5d415bf6b2e39de99f2668373a99cf262b66a8e3
Cr-Commit-Position: refs/heads/master@{#416241}

[dvadym, 2016-08-31 15:46:30]

Description was changed from

==========
remove Nope

BUG=NONE
==========

to

==========
Removing Nope button in Update password prompt according to mocks.

BUG=564674
==========

[dvadym, 2016-08-31 15:52:21]

dvadym@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dvadym, 2016-08-31 15:52:22]

Hi Dan,

 could you please review this CL? I'll send a link to mocks and a screenshot by
e-mail.

Regards,
Vadym

[gone, 2016-08-31 17:21:13]

You've got to pipe this in from an earlier point:
ConfirmInfoBarDelegate::GetButtons() tells the infobar framework which buttons
exist, and ConfirmInfoBarDelegate::GetLabelFor() tells the infobar what the
label should be.

You should:
* Override UpdatePasswordInfoBarDelegate::GetButtons() to
  say only the BUTTON_OK exists.

* Override UpdatePasswordInfoBarDelegate::GetLabelFor() to
  return nothing in that case.

That *might* make the rest of your change unnecessary.

[dvadym, 2016-09-01 18:11:05]

On 2016/08/31 17:21:13, dfalcantara wrote:
> You've got to pipe this in from an earlier point:
> ConfirmInfoBarDelegate::GetButtons() tells the infobar framework which buttons
> exist, and ConfirmInfoBarDelegate::GetLabelFor() tells the infobar what the
> label should be.
> 
> You should:
> * Override UpdatePasswordInfoBarDelegate::GetButtons() to
>   say only the BUTTON_OK exists.
> 
> * Override UpdatePasswordInfoBarDelegate::GetLabelFor() to
>   return nothing in that case.
> 
> That *might* make the rest of your change unnecessary.

Thanks Dan for comments! I've addressed them. PTAL

[gone, 2016-09-01 18:16:51]

lgtm

https://codereview.chromium.org/2298733003/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/update_password_infobar_delegate_android.cc
(right):

https://codereview.chromium.org/2298733003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/update_password_infobar_delegate_android.cc:110:
bool UpdatePasswordInfoBarDelegate::Cancel() {
nit: You can get rid of this function; the default seems to handle it just fine.

[dvadym, 2016-09-02 11:06:36]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 11:06:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 11:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 11:50:54]

Dry run: This issue passed the CQ dry run.

[dvadym, 2016-09-02 11:53:39]

Thanks Dan for review!

https://codereview.chromium.org/2298733003/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/update_password_infobar_delegate_android.cc
(right):

https://codereview.chromium.org/2298733003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/update_password_infobar_delegate_android.cc:110:
bool UpdatePasswordInfoBarDelegate::Cancel() {
On 2016/09/01 18:16:51, dfalcantara wrote:
> nit: You can get rid of this function; the default seems to handle it just
fine.

Done.

[dvadym, 2016-09-02 11:54:02]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2016-09-02 11:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2298733003/#ps40001
(title: "Remove Cancel")

[commit-bot: I haz the power, 2016-09-02 11:54:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 11:58:27]

Description was changed from

==========
Removing Nope button in Update password prompt according to mocks.

BUG=564674
==========

to

==========
Removing Nope button in Update password prompt according to mocks.

BUG=564674
==========

[commit-bot: I haz the power, 2016-09-02 11:58:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 12:00:02]

Description was changed from

==========
Removing Nope button in Update password prompt according to mocks.

BUG=564674
==========

to

==========
Removing Nope button in Update password prompt according to mocks.

BUG=564674

Committed: https://crrev.com/5d415bf6b2e39de99f2668373a99cf262b66a8e3
Cr-Commit-Position: refs/heads/master@{#416241}
==========

[commit-bot: I haz the power, 2016-09-02 12:00:03]

Patchset 3 (id:??) landed as
https://crrev.com/5d415bf6b2e39de99f2668373a99cf262b66a8e3
Cr-Commit-Position: refs/heads/master@{#416241}