Stop syncing content settings on Android

Stop syncing content settings on Android

Currently the UI on Android doesn't allow content settings to be
manipulated in the same ways as on desktop, which can leave users
in a broken state. Stop syncing them for now.

BUG=642184
Committed: https://crrev.com/905d12e32159a88e8495092a9271e9e3c7971449
Cr-Commit-Position: refs/heads/master@{#415829}

[raymes, 2016-08-31 01:20:01]

raymes@chromium.org changed reviewers:
+ lshang@chromium.org, msramek@chromium.org

[raymes, 2016-08-31 01:20:34]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 01:20:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 02:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 02:49:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[raymes, 2016-08-31 02:56:49]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 02:57:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 03:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 03:10:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[raymes, 2016-08-31 03:12:16]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 03:12:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 03:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 03:21:41]

Dry run: Exceeded global retry quota

[msramek, 2016-08-31 08:48:06]

LGTM, thanks!

https://codereview.chromium.org/2298633002/diff/20001/components/content_sett...
File components/content_settings/core/browser/website_settings_registry.cc
(right):

https://codereview.chromium.org/2298633002/diff/20001/components/content_sett...
components/content_settings/core/browser/website_settings_registry.cc:77: #elif
defined(OS_ANDROID)
optional nit: We could join the two blocks (i.e. !(platform & (PLATFORM_ANDROID
| PLATFORM_IOS)) since the comment applies to both of them.

[raymes, 2016-09-01 00:17:01]

https://codereview.chromium.org/2298633002/diff/20001/components/content_sett...
File components/content_settings/core/browser/website_settings_registry.cc
(right):

https://codereview.chromium.org/2298633002/diff/20001/components/content_sett...
components/content_settings/core/browser/website_settings_registry.cc:77: #elif
defined(OS_ANDROID)
On 2016/08/31 08:48:06, msramek wrote:
> optional nit: We could join the two blocks (i.e. !(platform &
(PLATFORM_ANDROID
> | PLATFORM_IOS)) since the comment applies to both of them.

Hmm I think it's about the same to leave them separate, just because this code
is already a bit mind-bending with the platform check inside the ifdef platform
check :) I'll copy the comment though so it's clear.

[raymes, 2016-09-01 00:17:22]

The CQ bit was checked by raymes@chromium.org

[raymes, 2016-09-01 00:17:22]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2298633002/#ps40001
(title: "Stop syncing content settings on Android")

[commit-bot: I haz the power, 2016-09-01 00:18:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:09:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 01:12:14]

Description was changed from

==========
Stop syncing content settings on Android

Currently the UI on Android doesn't allow content settings to be
manipulated in the same ways as on desktop, which can leave users
in a broken state. Stop syncing them for now.

BUG=642184
==========

to

==========
Stop syncing content settings on Android

Currently the UI on Android doesn't allow content settings to be
manipulated in the same ways as on desktop, which can leave users
in a broken state. Stop syncing them for now.

BUG=642184

Committed: https://crrev.com/905d12e32159a88e8495092a9271e9e3c7971449
Cr-Commit-Position: refs/heads/master@{#415829}
==========

[commit-bot: I haz the power, 2016-09-01 01:12:16]

Patchset 3 (id:??) landed as
https://crrev.com/905d12e32159a88e8495092a9271e9e3c7971449
Cr-Commit-Position: refs/heads/master@{#415829}

[lshang, 2016-09-02 00:50:54]

Acknowledged:-)