Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2298633002: Stop syncing content settings on Android (Closed)

Created:
4 years, 3 months ago by raymes
Modified:
4 years, 3 months ago
Reviewers:
msramek, lshang
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop syncing content settings on Android Currently the UI on Android doesn't allow content settings to be manipulated in the same ways as on desktop, which can leave users in a broken state. Stop syncing them for now. BUG=642184 Committed: https://crrev.com/905d12e32159a88e8495092a9271e9e3c7971449 Cr-Commit-Position: refs/heads/master@{#415829}

Patch Set 1 #

Patch Set 2 : Stop syncing content settings on Android #

Total comments: 2

Patch Set 3 : Stop syncing content settings on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M components/content_settings/core/browser/content_settings_registry_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/website_settings_registry.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M components/content_settings/core/browser/website_settings_registry_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
raymes
4 years, 3 months ago (2016-08-31 01:20:02 UTC) #2
msramek
LGTM, thanks! https://codereview.chromium.org/2298633002/diff/20001/components/content_settings/core/browser/website_settings_registry.cc File components/content_settings/core/browser/website_settings_registry.cc (right): https://codereview.chromium.org/2298633002/diff/20001/components/content_settings/core/browser/website_settings_registry.cc#newcode77 components/content_settings/core/browser/website_settings_registry.cc:77: #elif defined(OS_ANDROID) optional nit: We could join ...
4 years, 3 months ago (2016-08-31 08:48:06 UTC) #15
raymes
https://codereview.chromium.org/2298633002/diff/20001/components/content_settings/core/browser/website_settings_registry.cc File components/content_settings/core/browser/website_settings_registry.cc (right): https://codereview.chromium.org/2298633002/diff/20001/components/content_settings/core/browser/website_settings_registry.cc#newcode77 components/content_settings/core/browser/website_settings_registry.cc:77: #elif defined(OS_ANDROID) On 2016/08/31 08:48:06, msramek wrote: > optional ...
4 years, 3 months ago (2016-09-01 00:17:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298633002/40001
4 years, 3 months ago (2016-09-01 00:18:01 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 01:09:59 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/905d12e32159a88e8495092a9271e9e3c7971449 Cr-Commit-Position: refs/heads/master@{#415829}
4 years, 3 months ago (2016-09-01 01:12:16 UTC) #22
lshang
4 years, 3 months ago (2016-09-02 00:50:54 UTC) #23
Message was sent while issue was closed.
Acknowledged:-)

Powered by Google App Engine
This is Rietveld 408576698