Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2298613003: Remove --ignition-staging to --ignition-osr implication. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --ignition-staging to --ignition-osr implication. Ignition OSR to turbofan seems to cause instruction selector crashes (where instructions selector gets simplified operators, probably because we break the effect chain somehow). BUG=chromium:641893 Committed: https://crrev.com/26df3e230ebd8c7d1cd95ea54155959eee7cb830 Cr-Commit-Position: refs/heads/master@{#39045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Jarin
Could you take a look, please?
4 years, 3 months ago (2016-08-31 11:07:17 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-08-31 11:29:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298613003/1
4 years, 3 months ago (2016-08-31 11:31:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 11:35:57 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/26df3e230ebd8c7d1cd95ea54155959eee7cb830 Cr-Commit-Position: refs/heads/master@{#39045}
4 years, 3 months ago (2016-08-31 11:36:42 UTC) #11
Michael Starzinger
4 years, 3 months ago (2016-09-07 07:33:48 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2318943002/ by mstarzinger@chromium.org.

The reason for reverting is: Re-enable to get new data after recent changes..

Powered by Google App Engine
This is Rietveld 408576698