Issue 22986033: [Android WebView] Add an API to toggle the JS navigator.online property

Issue 22986033: [Android WebView] Add an API to toggle the JS navigator.online property (Closed)

Created:
7 years, 4 months ago by benm (inactive)

Modified:
7 years, 3 months ago

Reviewers:
palmer, joth, mkosiba (inactive), Chris Palmer

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android WebView] Add an API to toggle the JS navigator.online property BUG=279929 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219854

Patch Set 3 : Improve the test #

Patch Set 4 : Really improve the test #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -1 line)			Patch
M	android_webview/browser/renderer_host/aw_render_view_host_ext.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/browser/renderer_host/aw_render_view_host_ext.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	android_webview/common/render_view_messages.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_contents.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_contents.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	android_webview/renderer/aw_render_process_observer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/renderer/aw_render_process_observer.cc	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm +palmer for render_view_messages.h https://codereview.chromium.org/22986033/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/22986033/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode1635 android_webview/java/src/org/chromium/android_webview/AwContents.java:1635: if(mNativeAwContents != 0) { nit: ...

7 years, 4 months ago (2013-08-25 21:13:03 UTC) #1

benm (inactive)

thanks guys. will add a test too in next PS. (!) https://codereview.chromium.org/22986033/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): ...

7 years, 3 months ago (2013-08-27 09:46:36 UTC) #3

mkosiba (inactive)

https://codereview.chromium.org/22986033/diff/12001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java (right): https://codereview.chromium.org/22986033/diff/12001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java#newcode408 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:408: loadDataSync(awContents, loadHelper, HTML, "text/html", false); please use executeJavaScriptAndWaitForResult instead. ...

7 years, 3 months ago (2013-08-27 15:35:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/22986033/21001

7 years, 3 months ago (2013-08-27 17:27:10 UTC) #7

Message was sent while issue was closed.

Change committed as 219854

Expand Messages | Collapse Messages