Issue 2298603003: Update .gitignore to properly ignore base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2298603003: Update .gitignore to properly ignore base/ (Closed)

Created:
4 years, 3 months ago by Lei Zhang

Modified:
4 years, 3 months ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	.gitignore	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Lei Zhang

TBR As is, I suspect base/trace_events is still being deleted.

4 years, 3 months ago (2016-08-31 05:20:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298603003/1

4 years, 3 months ago (2016-08-31 05:20:30 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-08-31 06:16:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7e7ef3dd60a836521607d4b2ec41cbbe9501...