Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2298603002: chromeos: Remove Introspectable D-Bus client library (Closed)

Created:
4 years, 3 months ago by James Cook
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove Introspectable D-Bus client library This is unused and no longer needed. We can revive it from git history if we need it again. BUG=641996 TEST=compiles Committed: https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe Cr-Commit-Position: refs/heads/master@{#415679}

Patch Set 1 #

Patch Set 2 : readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -359 lines) Patch
M chromeos/chromeos.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M chromeos/dbus/README.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.h View 4 chunks +8 lines, -15 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 4 chunks +0 lines, -12 lines 0 comments Download
D chromeos/dbus/fake_introspectable_client.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chromeos/dbus/fake_introspectable_client.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chromeos/dbus/introspectable_client.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chromeos/dbus/introspectable_client.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D chromeos/dbus/introspectable_client_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
stevenjb, please take a look. This is the last of the D-Bus client library cleanup.
4 years, 3 months ago (2016-08-30 23:46:12 UTC) #4
stevenjb
lgtm
4 years, 3 months ago (2016-08-31 17:29:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298603002/20001
4 years, 3 months ago (2016-08-31 17:53:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 17:58:40 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:01:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe
Cr-Commit-Position: refs/heads/master@{#415679}

Powered by Google App Engine
This is Rietveld 408576698