Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: runtime/observatory/lib/src/elements/heap_snapshot.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/heap_snapshot.dart
diff --git a/runtime/observatory/lib/src/elements/heap_snapshot.dart b/runtime/observatory/lib/src/elements/heap_snapshot.dart
index e0771eb8fa4ed8a9e58bc611e56687554845a7b2..c488a65c5552bfa571bcd992723ba054b988ea48 100644
--- a/runtime/observatory/lib/src/elements/heap_snapshot.dart
+++ b/runtime/observatory/lib/src/elements/heap_snapshot.dart
@@ -266,31 +266,31 @@ class HeapSnapshotElement extends HtmlElement implements Renderable {
static Element _createDominator(toggle) {
return new DivElement()
- ..classes = const ['tree-item']
+ ..classes = ['tree-item']
..children = [
- new SpanElement()..classes = const ['size']
+ new SpanElement()..classes = ['size']
..title = 'retained size',
- new SpanElement()..classes = const ['lines'],
- new ButtonElement()..classes = const ['expander']
+ new SpanElement()..classes = ['lines'],
+ new ButtonElement()..classes = ['expander']
..onClick.listen((_) => toggle(autoToggleSingleChildNodes: true)),
- new SpanElement()..classes = const ['percentage']
+ new SpanElement()..classes = ['percentage']
..title = 'percentage of heap being retained',
- new SpanElement()..classes = const ['name']
+ new SpanElement()..classes = ['name']
];
}
static Element _createGroup(toggle) {
return new DivElement()
- ..classes = const ['tree-item']
+ ..classes = ['tree-item']
..children = [
- new SpanElement()..classes = const ['size']
+ new SpanElement()..classes = ['size']
..title = 'shallow size',
- new SpanElement()..classes = const ['lines'],
- new ButtonElement()..classes = const ['expander']
+ new SpanElement()..classes = ['lines'],
+ new ButtonElement()..classes = ['expander']
..onClick.listen((_) => toggle(autoToggleSingleChildNodes: true)),
- new SpanElement()..classes = const ['count']
+ new SpanElement()..classes = ['count']
..title = 'shallow size',
- new SpanElement()..classes = const ['name']
+ new SpanElement()..classes = ['name']
];
}
@@ -326,7 +326,7 @@ class HeapSnapshotElement extends HtmlElement implements Renderable {
}
element.children[3].text = Utils.formatPercentNormalized(
node.retainedSize * 1.0 / _snapshot.size);
- final wrapper = new SpanElement()..classes = const ['name']
+ final wrapper = new SpanElement()..classes = ['name']
..text = 'Loading...';
element.children[4] = wrapper;
node.object.then((object) {
@@ -342,7 +342,7 @@ class HeapSnapshotElement extends HtmlElement implements Renderable {
element.children[2].text = _tree.isExpanded(item) ? '▼' : '►';
element.children[3].text = '${item.instances} instances of ';
element.children[4] = new ClassRefElement(_isolate, item.clazz,
- queue: _r.queue)..classes = const ['name'];
+ queue: _r.queue)..classes = ['name'];
} else if (item is Iterable) {
element.children[0].text = '';
if (item.isNotEmpty) {
@@ -352,17 +352,17 @@ class HeapSnapshotElement extends HtmlElement implements Renderable {
}
element.children[3].text = '';
if (item is Iterable<M.HeapSnapshotClassInbound>) {
- element.children[4] = new SpanElement()..classes = const ['name']
+ element.children[4] = new SpanElement()..classes = ['name']
..text = '${item.length} Incoming references';
} else {
- element.children[4] = new SpanElement()..classes = const ['name']
+ element.children[4] = new SpanElement()..classes = ['name']
..text = '${item.length} Outgoing references';
}
} else {
element.children[0].text = '';
element.children[2].text = '';
element.children[3].text = '';
- element.children[4] = new SpanElement()..classes = const ['name'];
+ element.children[4] = new SpanElement()..classes = ['name'];
if (item is M.HeapSnapshotClassInbound){
element.children[3].text =
'${item.count} references from instances of ';
« no previous file with comments | « runtime/observatory/lib/src/elements/heap_map.dart ('k') | runtime/observatory/lib/src/elements/icdata_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698