runtime/observatory/lib/src/elements/containers/virtual_collection.dart - Issue 2298563002: Removed const from classes arrays in Observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/containers/virtual_collection.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/allocation_profile.dart ('k') | runtime/observatory/lib/src/elements/context_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/containers/virtual_collection.dart

diff --git a/runtime/observatory/lib/src/elements/containers/virtual_collection.dart b/runtime/observatory/lib/src/elements/containers/virtual_collection.dart

index d0973e2bca4be73a9cc3519d61e772724fa9f053..d8d6e1646ae83e365ec9446c362628fd31c84d77 100644

--- a/runtime/observatory/lib/src/elements/containers/virtual_collection.dart

+++ b/runtime/observatory/lib/src/elements/containers/virtual_collection.dart

@@ -77,9 +77,9 @@ class VirtualCollectionElement extends HtmlElement implements Renderable {

_onResizeSubscription.cancel();

}

- final DivElement _header = new DivElement()..classes = const ['header'];

- final DivElement _scroller = new DivElement()..classes = const ['scroller'];

- final DivElement _shifter = new DivElement()..classes = const ['shifter'];

+ final DivElement _header = new DivElement()..classes = ['header'];

+ final DivElement _scroller = new DivElement()..classes = ['scroller'];

+ final DivElement _shifter = new DivElement()..classes = ['shifter'];

dynamic getItemFromElement(HtmlElement element) {

final el_index = _shifter.children.indexOf(element);