Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2298533002: [MD settings] Show up to six on startup urls without scrolling (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] Show up to six on startup urls without scrolling This CL changes the height of the container for the On startup list of URLs to show up to six rows (scrolling to see the remaining rows). This was requested by Alan. BUG=603305 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/72679618a08ccd653fcca4efab460a5b2ebf0eac Cr-Commit-Position: refs/heads/master@{#415477}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
dschuyler
4 years, 3 months ago (2016-08-30 21:21:32 UTC) #8
tommycli
lgtm
4 years, 3 months ago (2016-08-30 21:26:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298533002/20001
4 years, 3 months ago (2016-08-30 22:53:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-30 22:59:40 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 23:02:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72679618a08ccd653fcca4efab460a5b2ebf0eac
Cr-Commit-Position: refs/heads/master@{#415477}

Powered by Google App Engine
This is Rietveld 408576698