Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2298513002: 🔖 Remove unmapped histogram ResourceBundle.LoadLocaleResourcesError (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unmapped histogram ResourceBundle.LoadLocaleResourcesError It was never added to histograms.xml BUG=642287 Committed: https://crrev.com/604aab6941881e425c26d899d147f60eacb8312f Cr-Commit-Position: refs/heads/master@{#415703}

Patch Set 1 #

Patch Set 2 : remove other histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M ui/base/resource/resource_bundle.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
agrieve
4 years, 3 months ago (2016-08-30 20:25:52 UTC) #2
sadrul
Looks like there's one in resource_bundle.cc (https://cs.chromium.org/chromium/src/ui/base/resource/resource_bundle.cc?q=LoadLocaleResourcesError&sq=package:chromium&dr=C&l=335). Remove that too? lgtm
4 years, 3 months ago (2016-08-31 15:44:24 UTC) #7
agrieve
On 2016/08/31 15:44:24, sadrul wrote: > Looks like there's one in resource_bundle.cc > (https://cs.chromium.org/chromium/src/ui/base/resource/resource_bundle.cc?q=LoadLocaleResourcesError&sq=package:chromium&dr=C&l=335). > ...
4 years, 3 months ago (2016-08-31 17:30:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298513002/10001
4 years, 3 months ago (2016-08-31 17:31:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 3 months ago (2016-08-31 18:52:43 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:54:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/604aab6941881e425c26d899d147f60eacb8312f
Cr-Commit-Position: refs/heads/master@{#415703}

Powered by Google App Engine
This is Rietveld 408576698