chrome/browser/resources/signin/signin_error/signin_error.html - Issue 2298503002: [Signin Error Dialog] (1/3) Adds necessary web components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/signin/signin_error/signin_error.html

Issue 2298503002: [Signin Error Dialog] (1/3) Adds necessary web components (Closed)

Patch Set: Use preprocess instead of flattenhtml Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/signin/signin_error/signin_error.js » ('j') | chrome/browser/resources/signin/signin_shared_css.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html i18n-values="dir:textdirection;lang:language">

	3 <head>

	4 <meta charset="utf-8">

	5 <link rel="import" href="chrome://resources/html/polymer.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html">

	8 <link rel="import" href="signin_shared_css.html">

	9 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

	10 <link rel="import" href="chrome://resources/html/cr.html">

	11 <style is="custom-style" include="signin-dialog-shared">

	12 .details {

	13 margin-bottom: 8px;

	14 margin-top: 16px;

	15 padding: 0 24px;

	16 }

	17

	18 #closeButton {

	19 -webkit-margin-start: 8px;

	20 }

	21

	22 <if expr="is_macosx or is_linux">

	23 #closeButton {

	24 -webkit-margin-end: 8px;

	25 -webkit-margin-start: 0;

	26 }

	27 </if>

	28 </style>

	29 </head>

	30 <body>

	31 <div class="container">

	32 <div class="top-title-bar">$i18n{signinErrorTitle}</div>

	33 <div class="details">$i18nRaw{signinErrorMessage}</div>

	34 <div class="action-container">

	35 <paper-button class="primary-action" id="switchButton">
	Dan Beam 2016/09/02 23:21:55 it'd be nice to use on-tap instead of addEventList it'd be nice to use on-tap instead of addEventListener() from the js, but this would probably have to be a real Polymer() element
	36 $i18n{signinErrorSwitchLabel}

	37 </paper-button>

	38 <paper-button class="secondary-action" id="closeButton">

	39 $i18n{signinErrorCloseLabel}

	40 </paper-button>

	41 <paper-button class="primary-action" id="confirmButton" hidden>

	42 $i18n{signinErrorOkLabel}

	43 </paper-button>

	44 </div>

	45 </div>

	46 </body>

	47 <script src="chrome://resources/js/load_time_data.js"></script>

	48 <script src="chrome://resources/js/util.js"></script>
	Dan Beam 2016/09/02 23:21:55 these should also be imports instead of scripts these should also be imports instead of scripts anthonyvd 2016/09/06 14:36:14 Done. Show quoted text On 2016/09/02 at 23:21:55, Dan Beam wrote: > these should also be imports instead of scripts Done.
	49 <script src="signin_error.js"></script>

	50 <script src="chrome://signin-error/strings.js"></script>

	51 </html>

OLD	NEW