Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 22985005: The length of scheme is at least five characters even when the scheme has 'web+' prefix (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

The length of scheme is at least five characters even when the scheme has 'web+' prefix The content-scheme handler specification requires that it is SecurityError if the length of scheme isn't five characters at least, including 'web+' prefix. Thus, we need to check the length of scheme on the 'web+' scheme. Spec: http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers BUG= N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M LayoutTests/fast/dom/register-protocol-handler.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/register-protocol-handler-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/unregister-protocol-handler.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/unregister-protocol-handler-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
The latest specification requires that it is a SecurityError if the length of scheme isn't ...
7 years, 4 months ago (2013-08-13 12:31:39 UTC) #1
abarth-chromium
lgtm
7 years, 4 months ago (2013-08-13 20:12:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/22985005/1
7 years, 4 months ago (2013-08-13 20:12:48 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 21:45:14 UTC) #4
Message was sent while issue was closed.
Change committed as 156049

Powered by Google App Engine
This is Rietveld 408576698