Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chrome/browser/accessibility/accessibility_extension_api.cc

Issue 2298493003: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/accessibility/accessibility_extension_api.cc
diff --git a/chrome/browser/accessibility/accessibility_extension_api.cc b/chrome/browser/accessibility/accessibility_extension_api.cc
index 737c2e3a981df96b471a15ab3fe36a11ff4c4f15..68f304ad8361869b3b88825ee086408e597a68a1 100644
--- a/chrome/browser/accessibility/accessibility_extension_api.cc
+++ b/chrome/browser/accessibility/accessibility_extension_api.cc
@@ -48,8 +48,9 @@ const char kHeight[] = "height";
const char kErrorNotSupported[] = "This API is not supported on this platform.";
} // namespace
-bool AccessibilityPrivateSetNativeAccessibilityEnabledFunction::RunSync() {
- bool enabled;
+ExtensionFunction::ResponseAction
+AccessibilityPrivateSetNativeAccessibilityEnabledFunction::Run() {
+ bool enabled = false;
EXTENSION_FUNCTION_VALIDATE(args_->GetBoolean(0, &enabled));
if (enabled) {
content::BrowserAccessibilityState::GetInstance()->
@@ -58,10 +59,11 @@ bool AccessibilityPrivateSetNativeAccessibilityEnabledFunction::RunSync() {
content::BrowserAccessibilityState::GetInstance()->
DisableAccessibility();
}
- return true;
+ return RespondNow(NoArguments());
}
-bool AccessibilityPrivateSetFocusRingFunction::RunSync() {
+ExtensionFunction::ResponseAction
+AccessibilityPrivateSetFocusRingFunction::Run() {
#if defined(OS_CHROMEOS)
base::ListValue* rect_values = NULL;
EXTENSION_FUNCTION_VALIDATE(args_->GetList(0, &rect_values));
@@ -90,11 +92,10 @@ bool AccessibilityPrivateSetFocusRingFunction::RunSync() {
manager->SetTouchAccessibilityAnchorPoint(rects[0].CenterPoint());
}
- return true;
+ return RespondNow(NoArguments());
#endif // defined(OS_CHROMEOS)
- error_ = kErrorNotSupported;
- return false;
+ return RespondNow(Error(kErrorNotSupported));
}
ExtensionFunction::ResponseAction
« no previous file with comments | « chrome/browser/accessibility/accessibility_extension_api.h ('k') | chrome/browser/chromeos/extensions/echo_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698