Make LIBRARY_CYCLE_UNITS and LIBRARY_CYCLE_DEPENDENCIES be List<LibrarySpecificUnit>.

Make LIBRARY_CYCLE_UNITS and LIBRARY_CYCLE_DEPENDENCIES be List<LibrarySpecificUnit>.

I expected some performance gains by avoiding creating LSU instances
multiple times, but don't see any difference.

However this makes flutter-memory-initialAnalysis-2 benchmark use
about 2.5% less memory.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a92f54c746a22ddd5b54bf7b732d671531df7113

[Brian Wilkerson, 2016-08-30 20:18:02]

I had a more general way of reducing the number of LSU's
(https://codereview.chromium.org/2151373002/), but if this is better then I
guess lgtm.

[scheglov, 2016-08-30 20:26:49]

On 2016/08/30 20:18:02, Brian Wilkerson wrote:
> I had a more general way of reducing the number of LSU's
> (https://codereview.chromium.org/2151373002/), but if this is better then I
> guess lgtm.

AFAIK these CLs solve the same problem for the number LSU instances, but don't
actually intersect.

[scheglov, 2016-08-30 20:54:00]

Description was changed from

==========
Make LIBRARY_CYCLE_UNITS and LIBRARY_CYCLE_DEPENDENCIES be
List<LibrarySpecificUnit>.

I expected some performance gains by avoiding creating LSU instances
multiple times, but don't see any difference.

However this makes flutter-memory-initialAnalysis-2 benchmark use
about 2.5% less memory.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Make LIBRARY_CYCLE_UNITS and LIBRARY_CYCLE_DEPENDENCIES be
List<LibrarySpecificUnit>.

I expected some performance gains by avoiding creating LSU instances
multiple times, but don't see any difference.

However this makes flutter-memory-initialAnalysis-2 benchmark use
about 2.5% less memory.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a92f54c746a22ddd5b54bf7b732d671531df7113
==========

[scheglov, 2016-08-30 20:54:01]

Committed patchset #1 (id:1) manually as
a92f54c746a22ddd5b54bf7b732d671531df7113 (presubmit successful).