Always add a barrier when old layout was general in vulkan.

Always add a barrier when old layout was general in vulkan.

When we have a general layout, we need to always add a barrier even if
leaving the layout in general since we don't know what the use case for
general was with the old layout.

This doesn't seem to fix any of our synchronization issues which makes
sense since we don't really use a general layout much. The only place it
is used is for mipmap generation, but then we add explicit barriers in
that function itself and the first use of the image after mipmap generation
will change the layout to something other than general, usually SHADER_READ.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298483002

Committed: https://skia.googlesource.com/skia/+/19ff1035d3334ffa513c93edce04662bb5ead5bd

[egdaniel, 2016-08-30 19:48:18]

Description was changed from

==========
Always add a barrier when old layout was general in vulkan.

When we have a general layout, we need to always add a barrier even if
leaving the layout in general since we don't know what the use case for
general was with the old layout.

This doesn't seem to fix any of our synchronization issues which makes
sense since we don't really use a general layout much. The only place it
is used is for mipmap generation, but then we add explicit barriers in
that function itself and the first use of the image after mipmap generation
will change the layout to something other than general, usually SHADER_READ.

BUG=skia:
==========

to

==========
Always add a barrier when old layout was general in vulkan.

When we have a general layout, we need to always add a barrier even if
leaving the layout in general since we don't know what the use case for
general was with the old layout.

This doesn't seem to fix any of our synchronization issues which makes
sense since we don't really use a general layout much. The only place it
is used is for mipmap generation, but then we add explicit barriers in
that function itself and the first use of the image after mipmap generation
will change the layout to something other than general, usually SHADER_READ.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298483002
==========

[egdaniel, 2016-08-30 19:50:03]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-08-30 19:50:08]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-08-30 19:50:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:50:19]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-08-31 01:50 UTC

[egdaniel, 2016-08-30 20:08:00]

The CQ bit was unchecked by egdaniel@google.com

[egdaniel, 2016-08-30 20:24:24]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-08-30 20:24:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:24:31]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-08-31 02:24 UTC

[commit-bot: I haz the power, 2016-08-31 02:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 02:24:29]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[egdaniel, 2016-08-31 13:04:33]

ping

[jvanverth1, 2016-08-31 17:07:01]

lgtm

[egdaniel, 2016-08-31 17:12:05]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-08-31 17:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:13:11]

Description was changed from

==========
Always add a barrier when old layout was general in vulkan.

When we have a general layout, we need to always add a barrier even if
leaving the layout in general since we don't know what the use case for
general was with the old layout.

This doesn't seem to fix any of our synchronization issues which makes
sense since we don't really use a general layout much. The only place it
is used is for mipmap generation, but then we add explicit barriers in
that function itself and the first use of the image after mipmap generation
will change the layout to something other than general, usually SHADER_READ.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298483002
==========

to

==========
Always add a barrier when old layout was general in vulkan.

When we have a general layout, we need to always add a barrier even if
leaving the layout in general since we don't know what the use case for
general was with the old layout.

This doesn't seem to fix any of our synchronization issues which makes
sense since we don't really use a general layout much. The only place it
is used is for mipmap generation, but then we add explicit barriers in
that function itself and the first use of the image after mipmap generation
will change the layout to something other than general, usually SHADER_READ.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298483002

Committed:
https://skia.googlesource.com/skia/+/19ff1035d3334ffa513c93edce04662bb5ead5bd
==========

[commit-bot: I haz the power, 2016-08-31 17:13:12]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/19ff1035d3334ffa513c93edce04662bb5ead5bd