Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2298443002: Rename CPDFSDK_BFAnnotHandler and CPDFSDK_XFAAnnotHandler. (Closed)

Created:
4 years, 3 months ago by jaepark
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CPDFSDK_BFAnnotHandler and CPDFSDK_XFAAnnotHandler. CPDFSDK_BFAnnotHandler handles CPDFSDK_Widget, so rename it to CPDFSDK_WidgetHandler. Similarly, CPDFSDK_XFAAnnotHandler handles CPDFSDK_XFAWidget, so rename it to CPDFSDK_XFAWidgetHandler. Committed: https://pdfium.googlesource.com/pdfium/+/8c54182aba447f7fbd6e763a559bec99ab996613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -1132 lines) Patch
M BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
D fpdfsdk/cpdfsdk_bfannothandler.cpp View 1 chunk +0 lines, -311 lines 0 comments Download
A + fpdfsdk/cpdfsdk_widgethandler.cpp View 9 chunks +85 lines, -85 lines 0 comments Download
D fpdfsdk/cpdfsdk_xfaannothandler.cpp View 1 chunk +0 lines, -386 lines 0 comments Download
A + fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 21 chunks +89 lines, -89 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_annothandlermgr.h View 2 chunks +4 lines, -4 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_bfannothandler.h View 1 chunk +0 lines, -121 lines 0 comments Download
A + fpdfsdk/include/cpdfsdk_widgethandler.h View 3 chunks +6 lines, -6 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_xfaannothandler.h View 1 chunk +0 lines, -113 lines 0 comments Download
A + fpdfsdk/include/cpdfsdk_xfawidgethandler.h View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jaepark
4 years, 3 months ago (2016-08-30 20:34:37 UTC) #6
dsinclair
lgtm
4 years, 3 months ago (2016-08-30 20:42:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298443002/1
4 years, 3 months ago (2016-08-30 20:42:49 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:43:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8c54182aba447f7fbd6e763a559bec99ab99...

Powered by Google App Engine
This is Rietveld 408576698