Issue 22984005: Revert 217172 "Enable high resolution time for TimeTicks::Now on..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22984005: Revert 217172 "Enable high resolution time for TimeTicks::Now on..." (Closed)

Created:
7 years, 4 months ago by nhiroki

Modified:
7 years, 4 months ago

Reviewers:
James Simonsen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 217172 "Enable high resolution time for TimeTicks::Now on..." There is a suspicion that this might break some tests: MessageLoopTest.PostDelayedTask_InPostOrder_2, StatsTableTest.StatsCounterTimer TimeTicks.Deltas http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/30128 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/21737 > Enable high resolution time for TimeTicks::Now on Windows Canary > > This should be unnoticeable, except for improved resolution in places such as window.performance.now(). > > The feature is enabled if the user is running Canary channel or has manually specified the --enable-high-resolution-time flag. This will only work if the CPU has a non-stop TSC and isn't a broken Athlon processor. UMA data show this is a safe combination. > > The flag is propagated to renderer processes so that they know to enable it too. > > BUG=158234 > > Review URL: https://chromiumcodereview.appspot.com/16896018 TBR=simonjam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217226

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -90 lines)			Patch
M	trunk/src/base/profiler/tracked_time.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/base/test/test_suite.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/base/time/time.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	trunk/src/base/time/time_win.cc	View	5 chunks	+4 lines, -44 lines	0 comments	Download
M	trunk/src/chrome/browser/chrome_browser_main_win.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	trunk/src/content/app/content_main_runner.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/content/browser/browser_child_process_host_impl.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/content/public/common/content_switches.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/content/public/common/content_switches.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r217226.