Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2298393002: [HBD] Fix Widevine breakage introduced by prior patch (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[HBD] Fix Widevine breakage introduced by prior patch Breakage introduced by prior patch here: https://codereview.chromium.org/2208463002 We had split off GetPluginContentSetting into a utils file, but forgot to add the widevine header file include. This means that WIDEVINE_CDM_AVAILABLE is never defined, and the Widevine-treated-as-JavaScript for content settings clause is never activated, breaking Widevine on Corp machines. BUG=641706 Review-Url: https://codereview.chromium.org/2295563002 Cr-Commit-Position: refs/heads/master@{#415339} (cherry picked from commit ff96ea580802bcc6910c930d636a3d6edb82de9a) Committed: https://chromium.googlesource.com/chromium/src/+/b72492925daed3c67251162f73837be963d6ef1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/plugins/plugin_filter_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tommycli
4 years, 3 months ago (2016-08-31 20:44:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b72492925daed3c67251162f73837be963d6ef1f.

Powered by Google App Engine
This is Rietveld 408576698