Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2298383002: Fix misspelling of object counts affecting Windows. (Closed)

Created:
4 years, 3 months ago by Sigurður Ásgeirsson
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix misspelling of object counts affecting Windows. BUG=642417 Committed: https://crrev.com/52114f27ab25db9aa6a1e635ff29e59e293d09b1 Cr-Commit-Position: refs/heads/master@{#415809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/trace_event/malloc_dump_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Sigurður Ásgeirsson
PTAL - I believe this mis-transcription from the winheap implementation is causing the grief.
4 years, 3 months ago (2016-08-31 20:31:59 UTC) #4
ssid
lgtm
4 years, 3 months ago (2016-08-31 21:07:13 UTC) #5
Primiano Tucci (use gerrit)
aaaaaaaaaaaa LGTM thanks. missed that in my review. once this lands and bug droid updates ...
4 years, 3 months ago (2016-08-31 21:11:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298383002/1
4 years, 3 months ago (2016-08-31 23:46:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 23:51:47 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:53:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52114f27ab25db9aa6a1e635ff29e59e293d09b1
Cr-Commit-Position: refs/heads/master@{#415809}

Powered by Google App Engine
This is Rietveld 408576698