Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js

Issue 2298373002: DevTools: remove indirection between CSSWorkspaceBindings and CSS mappings (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
index 6b1d3b388c6eb077eb91c4d35a102c987a17cd5d..89138574807f4642b10c5086c06dd64bfd0d86c8 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
@@ -159,33 +159,10 @@ WebInspector.CSSWorkspaceBinding.TargetInfo = function(cssModel, workspace, netw
/** @type {!Multimap<!WebInspector.CSSStyleSheetHeader, !WebInspector.LiveLocation>} */
this._locations = new Multimap();
-
- cssModel.addEventListener(WebInspector.CSSModel.Events.StyleSheetAdded, this._styleSheetAdded, this);
- cssModel.addEventListener(WebInspector.CSSModel.Events.StyleSheetRemoved, this._styleSheetRemoved, this);
}
WebInspector.CSSWorkspaceBinding.TargetInfo.prototype = {
/**
- * @param {!WebInspector.Event} event
- */
- _styleSheetAdded: function(event)
- {
- var header = /** @type {!WebInspector.CSSStyleSheetHeader} */ (event.data);
- this._stylesSourceMapping.addHeader(header);
- this._sassSourceMapping.addHeader(header);
- },
-
- /**
- * @param {!WebInspector.Event} event
- */
- _styleSheetRemoved: function(event)
- {
- var header = /** @type {!WebInspector.CSSStyleSheetHeader} */ (event.data);
- this._stylesSourceMapping.removeHeader(header);
- this._sassSourceMapping.removeHeader(header);
- },
-
- /**
* @param {!WebInspector.CSSWorkspaceBinding.LiveLocation} location
*/
_addLocation: function(location)
@@ -229,8 +206,8 @@ WebInspector.CSSWorkspaceBinding.TargetInfo.prototype = {
_dispose: function()
{
- this._cssModel.removeEventListener(WebInspector.CSSModel.Events.StyleSheetAdded, this._styleSheetAdded, this);
- this._cssModel.removeEventListener(WebInspector.CSSModel.Events.StyleSheetRemoved, this._styleSheetRemoved, this);
+ this._stylesSourceMapping.dispose();
+ this._sassSourceMapping.dispose();
}
}

Powered by Google App Engine
This is Rietveld 408576698