DevTools: remove indirection between CSSWorkspaceBindings and CSS mappings

third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
  * @constructor
  * @param {!WebInspector.CSSModel} cssModel
  * @param {!WebInspector.NetworkMapping} networkMapping
  * @param {!WebInspector.NetworkProject} networkProject
  */
 WebInspector.SASSSourceMapping = function(cssModel, networkMapping, networkProject)
 {
     this._cssModel = cssModel;
     this._networkProject = networkProject;
     this._networkMapping = networkMapping;
-    this._cssModel.addEventListener(WebInspector.CSSModel.Events.SourceMapAttached, this._sourceMapAttached, this);
-    this._cssModel.addEventListener(WebInspector.CSSModel.Events.SourceMapDetached, this._sourceMapDetached, this);
-    this._cssModel.addEventListener(WebInspector.CSSModel.Events.SourceMapChanged, this._sourceMapChanged, this);
+    this._eventListeners = [
+        this._cssModel.addEventListener(WebInspector.CSSModel.Events.SourceMapAttached, this._sourceMapAttached, this),
+        this._cssModel.addEventListener(WebInspector.CSSModel.Events.SourceMapDetached, this._sourceMapDetached, this),
+        this._cssModel.addEventListener(WebInspector.CSSModel.Events.SourceMapChanged, this._sourceMapChanged, this)
+    ];
 }
 
 WebInspector.SASSSourceMapping.prototype = {
     /**
      * @param {!WebInspector.Event} event
      */
     _sourceMapAttached: function(event)
     {
         var header = /** @type {!WebInspector.CSSStyleSheetHeader} */ (event.data);
         var sourceMap = this._cssModel.sourceMapForHeader(header);
@@ skipping 35 matching lines @@
                 if (handledUISourceCodes.has(uiSourceCode))
                     continue;
                 handledUISourceCodes.add(uiSourceCode);
                 var sassText = /** @type {string} */(newSources.get(sourceURL));
                 uiSourceCode.setWorkingCopy(sassText);
             }
         }
     },
 
     /**
-     * @param {!WebInspector.CSSStyleSheetHeader} header
-     */
-    addHeader: function(header)
-    {
-        if (!header.sourceMapURL)
-            return;
-        WebInspector.cssWorkspaceBinding.updateLocations(header);
-    },
-
-    /**
-     * @param {!WebInspector.CSSStyleSheetHeader} header
-     */
-    removeHeader: function(header)
-    {
-        if (!header.sourceMapURL)
-            return;
-        WebInspector.cssWorkspaceBinding.updateLocations(header);

[dgozman, 2016/09/01 00:49:25]

Who calls this now?

[lushnikov, 2016/09/01 01:34:34]

SourceMapDetached will call this (if there was a sourceMap attached)

-    },
-
-    /**
      * @param {!WebInspector.CSSLocation} rawLocation
      * @return {?WebInspector.UILocation}
      */
     rawLocationToUILocation: function(rawLocation)
     {
         var sourceMap = this._cssModel.sourceMapForHeader(rawLocation.header());
         if (!sourceMap)
             return null;
         var entry = sourceMap.findEntry(rawLocation.lineNumber, rawLocation.columnNumber);
         if (!entry || !entry.sourceURL)
             return null;
         var uiSourceCode = this._networkMapping.uiSourceCodeForStyleURL(entry.sourceURL, rawLocation.header());
         if (!uiSourceCode)
             return null;
         return uiSourceCode.uiLocation(entry.sourceLineNumber || 0, entry.sourceColumnNumber);
     },
+
+    dispose: function()
+    {
+        WebInspector.EventTarget.removeEventListeners(this._eventListeners);
+    }
 }