ui/ozone/platform/drm/gpu/gbm_buffer.cc - Issue 2298353002: gfx: Use unsigned strides for gpu memory buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/gbm_buffer.cc

Issue 2298353002: gfx: Use unsigned strides for gpu memory buffers. (Closed)

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/ozone/platform/drm/gpu/gbm_buffer.cc

diff --git a/ui/ozone/platform/drm/gpu/gbm_buffer.cc b/ui/ozone/platform/drm/gpu/gbm_buffer.cc

index 2235b707906932e5a9d4b7550b0d330c4cb41734..41cfdb7dbea1ff563cfb7ede1a2af90f2709584e 100644

--- a/ui/ozone/platform/drm/gpu/gbm_buffer.cc

+++ b/ui/ozone/platform/drm/gpu/gbm_buffer.cc

@@ -152,7 +152,7 @@ scoped_refptr<GbmBuffer> GbmBuffer::CreateBufferFromFds(

TRACE_EVENT2("drm", "GbmBuffer::CreateBufferFromFD", "device",

gbm->device_path().value(), "size", size.ToString());

DCHECK_LE(fds.size(), planes.size());

- DCHECK_EQ(planes[0].offset, 0);

+ DCHECK_EQ(planes[0].offset, 0u);

uint32_t fourcc_format = GetFourCCFormatFromBufferFormat(format);