cc/raster/one_copy_raster_buffer_provider.cc - Issue 2298353002: gfx: Use unsigned strides for gpu memory buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/raster/one_copy_raster_buffer_provider.cc

Issue 2298353002: gfx: Use unsigned strides for gpu memory buffers. (Closed)

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/raster/one_copy_raster_buffer_provider.cc

diff --git a/cc/raster/one_copy_raster_buffer_provider.cc b/cc/raster/one_copy_raster_buffer_provider.cc

index 31dad67aa86489218b4c6a3444b6c5c1dd656c92..33b8d3273f8cfc933b41cc5025860b4fa80078ad 100644

--- a/cc/raster/one_copy_raster_buffer_provider.cc

+++ b/cc/raster/one_copy_raster_buffer_provider.cc

@@ -250,8 +250,6 @@ void OneCopyRasterBufferProvider::PlaybackToStagingBuffer(

bool rv = buffer->Map();

DCHECK(rv);

DCHECK(buffer->memory(0));

- // RasterBufferProvider::PlaybackToMemory only supports unsigned strides.

- DCHECK_GE(buffer->stride(0), 0);

DCHECK(!playback_rect.IsEmpty())

<< "Why are we rastering a tile that's not dirty?";