Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2298323002: Makes chrome data_dep specific to chromeos (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes chrome data_dep specific to chromeos It's only needed for --run-in-mash, which is chromeos specific. BUG=none TEST=none R=sadrul@chromium.org Committed: https://crrev.com/71391dec3ded9b23cc6742fa5c3687e53f72bc87 Cr-Commit-Position: refs/heads/master@{#415744}

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : revert synced to tip of tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -135 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/BUILD.gn View 1 2 11 chunks +122 lines, -49 lines 0 comments Download
M ash/ash.gyp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M ash/mus/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/DEPS View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M ash/test/ash_test_base.h View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A ash/test/ash_test_environment.h View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A ash/test/ash_test_environment_content.h View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A ash/test/ash_test_environment_content.cc View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A ash/test/ash_test_environment_default.cc View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
M ash/test/ash_test_helper.h View 1 2 7 chunks +5 lines, -23 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 10 chunks +10 lines, -19 lines 0 comments Download
M ash/test/ash_test_helper_unittest.cc View 1 2 5 chunks +13 lines, -9 lines 0 comments Download
M ash/test/ash_test_views_delegate.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/ash_test_views_delegate.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
A + ash/test/content/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 4 chunks +7 lines, -3 lines 0 comments Download
A chrome/test/base/ash_test_environment_chrome.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/test/base/ash_test_environment_chrome.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M components/exo/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years, 3 months ago (2016-08-31 18:02:19 UTC) #1
sadrul
lgtm
4 years, 3 months ago (2016-08-31 19:36:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298323002/20001
4 years, 3 months ago (2016-08-31 20:39:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 20:45:04 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:48:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71391dec3ded9b23cc6742fa5c3687e53f72bc87
Cr-Commit-Position: refs/heads/master@{#415744}

Powered by Google App Engine
This is Rietveld 408576698