Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 22983003: Revert 217130 "On uninstall, delete shortcuts first, and then re..." (Closed)

Created:
7 years, 4 months ago by ncarter (slow)
Modified:
7 years, 4 months ago
Reviewers:
gab, huangs
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 217130 "On uninstall, delete shortcuts first, and then re..." [Reason for revert: compile failure on Win Aura (maybe due to merge conflict)] > On uninstall, delete shortcuts first, and then remove directory only if empty. > > Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are: > - Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu). > - If the directory becomes empty, then remove it; otherwise do nothing. > > The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior. > > BUG=235857 > > Review URL: https://chromiumcodereview.appspot.com/22870004 TBR=huangs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
trunk/src/chrome/installer/util/shell_util.cc View 3 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ncarter (slow)
7 years, 4 months ago (2013-08-13 00:38:49 UTC) #1
ncarter (slow)
Committed patchset #1 manually as r217134.
7 years, 4 months ago (2013-08-13 00:39:03 UTC) #2
gab
Hmmm.. the win7_aura bot had passed on the original CQ, seems extremely unlikely that this ...
7 years, 4 months ago (2013-08-13 18:04:05 UTC) #3
ncarter (slow)
There were two changes to this file that went through the CQ at the same ...
7 years, 4 months ago (2013-08-13 19:30:21 UTC) #4
huangs
7 years, 4 months ago (2013-08-14 18:12:18 UTC) #5
Message was sent while issue was closed.
LGTM. I'll merge the change into a synched checkout and resubmit.

Powered by Google App Engine
This is Rietveld 408576698