Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2298293002: Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
borenet, hinoka
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil The latter is being removed in https://codereview.chromium.org/2280023003/ Is also pinned to 3.25, whereas the former is updated more often. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002 Committed: https://skia.googlesource.com/skia/+/f15590f803596f51d0950994b2aeb623d2d1fc24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M infra/bots/recipes/swarm_housekeeper.py View 1 chunk +1 line, -2 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 chunk +1 line, -2 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Ryan Tseng
ptal, now on the skia side
4 years, 3 months ago (2016-08-31 17:29:49 UTC) #5
borenet
LGTM. Aside: CQ is broken due to https://bugs.chromium.org/p/chromium/issues/detail?id=642796
4 years, 3 months ago (2016-08-31 17:33:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298293002/1
4 years, 3 months ago (2016-09-19 18:30:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f15590f803596f51d0950994b2aeb623d2d1fc24
4 years, 3 months ago (2016-09-19 19:18:57 UTC) #12
borenet
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2355943002/ by borenet@google.com. ...
4 years, 3 months ago (2016-09-20 19:33:06 UTC) #13
hinoka
4 years, 3 months ago (2016-09-20 19:44:47 UTC) #15
Message was sent while issue was closed.
A straight revert may be problematic, I've rolled out the depot_tools side
change.

The running script will have to pass in "--" to separate args to the wrapper
from args to the real gsutil.  I'll send out another CL shortly

Powered by Google App Engine
This is Rietveld 408576698