Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6038)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 2298283002: Site Settings Desktop: Support adding exceptions for incognito mode. (Closed)
Patch Set: Fix test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 071a24e705a6fa114f303c38f559900c879306e5..503ea0ba4ffc29e7cb2276e9b0916e3e28f7dfc9 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -948,7 +948,7 @@ void ContentSettingsHandler::CompareMediaExceptionsWithFlash(
base::ListValue exceptions;
site_settings::GetExceptionsFromHostContentSettingsMap(settings_map, type,
- web_ui(), &exceptions);
+ web_ui(), /*incognito=*/ false, &exceptions);
settings.exceptions.clear();
for (base::ListValue::const_iterator entry = exceptions.begin();
@@ -1093,11 +1093,10 @@ void ContentSettingsHandler::UpdateExceptionsViewFromHostContentSettingsMap(
HostContentSettingsMap* settings_map =
HostContentSettingsMapFactory::GetForProfile(GetProfile());
site_settings::GetExceptionsFromHostContentSettingsMap(settings_map, type,
- web_ui(), &exceptions);
+ web_ui(), /*incognito=*/ false, &exceptions);
base::StringValue type_string(
site_settings::ContentSettingsTypeToGroupName(type));
web_ui()->CallJavascriptFunctionUnsafe("ContentSettings.setExceptions",
-
type_string, exceptions);
UpdateExceptionsViewFromOTRHostContentSettingsMap(type);
@@ -1128,8 +1127,8 @@ void ContentSettingsHandler::UpdateExceptionsViewFromOTRHostContentSettingsMap(
if (!otr_settings_map)
return;
base::ListValue exceptions;
- site_settings::GetExceptionsFromHostContentSettingsMap(
- otr_settings_map, type, web_ui(), &exceptions);
+ site_settings::GetExceptionsFromHostContentSettingsMap(otr_settings_map, type,
+ web_ui(), /*incognito=*/ true, &exceptions);
base::StringValue type_string(
site_settings::ContentSettingsTypeToGroupName(type));
web_ui()->CallJavascriptFunctionUnsafe("ContentSettings.setOTRExceptions",

Powered by Google App Engine
This is Rietveld 408576698