Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc

Issue 2298273002: Initial exclusion aware layout opportunities implementation (Closed)
Patch Set: Initial exclusion aware layout opportunities implementation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc
index b1229424b91ac783c76ecba5a7f27268ec02e871..2358ff6a7c1448ddf9f23af9dc3cd1c0ed0b4af5 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc
@@ -40,16 +40,16 @@ NGPhysicalConstraintSpace::NGPhysicalConstraintSpace(
height_direction_fragmentation_type_(
other.height_direction_fragmentation_type_) {}
-void NGPhysicalConstraintSpace::AddExclusion(const NGExclusion,
+void NGPhysicalConstraintSpace::AddExclusion(const NGExclusion exclusion,
unsigned options) {
- // TODO(layout-ng): Implement.
+ exclusions_.append(exclusion);
}
-const DoublyLinkedList<const NGExclusion>*
-NGPhysicalConstraintSpace::Exclusions(unsigned options) const {
+const Vector<NGExclusion>& NGPhysicalConstraintSpace::Exclusions(
+ unsigned options) const {
// TODO(layout-ng): Filter based on options? Perhaps layout Opportunities
// should filter instead?
- return &exclusions_;
+ return exclusions_;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698