Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2298253002: Add read/write-Pixels to GrDrawContext (Closed)

Created:
4 years, 3 months ago by robertphillips
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add read/write-Pixels to GrDrawContext Although not absolutely required this does remove another case where the drawContext's backing store is accessed. Broken out of: https://codereview.chromium.org/2215323003/ (Start using RenderTargetProxy (omnibus)) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298253002 Committed: https://skia.googlesource.com/skia/+/1da3ecd07836a72c9225c896d2516625906b4bda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -27 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +28 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +34 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +5 lines, -27 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
robertphillips
4 years, 3 months ago (2016-08-31 16:00:55 UTC) #5
bsalomon
lgtm. Curious what the long term plan is for read/write pixels WRT GrSurface/GrContext/GrDC.
4 years, 3 months ago (2016-08-31 17:58:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298253002/1
4 years, 3 months ago (2016-08-31 21:53:22 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:54:18 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1da3ecd07836a72c9225c896d2516625906b4bda

Powered by Google App Engine
This is Rietveld 408576698