Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/about_flags.cc

Issue 2298223002: Fix logging of Launch.FlagsAtStartup histogram. (Closed)
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/flags_ui/flags_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index bdd12c64d47f30cfee2c71f1bf86c462cb9f925d..c247b45e1218723501cac192edca8f1e78820fe2 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2184,8 +2184,9 @@ void ResetAllFlags(flags_ui::FlagsStorage* flags_storage) {
}
void RecordUMAStatistics(flags_ui::FlagsStorage* flags_storage) {
- std::set<std::string> flags = flags_storage->GetFlags();
- ReportAboutFlagsHistogram("Launch.FlagsAtStartup", flags);
+ const std::set<std::string> switches =
+ FlagsStateSingleton::GetFlagsState()->GetSwitchesFromFlags(flags_storage);
+ ReportAboutFlagsHistogram("Launch.FlagsAtStartup", switches);
}
base::HistogramBase::Sample GetSwitchUMAId(const std::string& switch_name) {
« no previous file with comments | « no previous file | components/flags_ui/flags_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698