Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2298213005: Merge "arc: Fix mouse scroll on notification" (Closed)

Created:
4 years, 3 months ago by xiyuan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge "arc: Fix mouse scroll on notification" > Forward ScrollEvent/MouseWheelEvent to the hosting widget so that > it is processed and reaches the containing ScrollView. > > Also not forward touch events to ArcCustomNotificationView since > a View is not supposed to receive touch events. This gets rid of > the NOTREACHED() warning in chrome log. > > BUG=b/31115616 > BUG=642501 > > Review-Url: https://codereview.chromium.org/2291193003 > Cr-Commit-Position: refs/heads/master@{#415708} > (cherry picked from commit c00a606faa2cd8099f9d88abe08e93c7418fb1fb) Committed: https://chromium.googlesource.com/chromium/src/+/1c40f86a91349db50b862e537694bd6821598f19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
4 years, 3 months ago (2016-09-01 18:15:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c40f86a91349db50b862e537694bd6821598f19.

Powered by Google App Engine
This is Rietveld 408576698