Reland "Fix form resubmissions happening silently."

Reland "Fix form resubmissions happening silently."

This reverts commit 9f3fcfea463d525af6b525318998edb72c09a7e1.

BUG=263508
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157253

[Nate Chapin, 2013-08-27 21:12:41]

https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
File Source/core/fetch/ResourceFetcher.cpp (left):

https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
Source/core/fetch/ResourceFetcher.cpp:628: return ReturnCacheDataDontLoad;
This deletion is the only diff from what I attempted to land a few weeks ago.

[abarth-chromium, 2013-08-27 23:39:44]

https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
File Source/core/fetch/ResourceFetcher.cpp (left):

https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
Source/core/fetch/ResourceFetcher.cpp:628: return ReturnCacheDataDontLoad;
On 2013/08/27 21:12:41, Nate Chapin wrote:
> This deletion is the only diff from what I attempted to land a few weeks ago.

We talked about this in person.  I think this line of code is correct.  The test
sets no-store but I think it's supposed to set no-cache to prevent caching.

[Nate Chapin, 2013-08-30 19:59:47]

On 2013/08/27 23:39:44, abarth wrote:
>
https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
> File Source/core/fetch/ResourceFetcher.cpp (left):
> 
>
https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
> Source/core/fetch/ResourceFetcher.cpp:628: return ReturnCacheDataDontLoad;
> On 2013/08/27 21:12:41, Nate Chapin wrote:
> > This deletion is the only diff from what I attempted to land a few weeks
ago.
> 
> We talked about this in person.  I think this line of code is correct.  The
test
> sets no-store but I think it's supposed to set no-cache to prevent caching.

+darin

The android test NavigationHistoryTest.testNavigateBackToNoncacheableLoginPage
appears to be incorrectly setting

[Nate Chapin, 2013-08-30 20:02:02]

On 2013/08/30 19:59:47, Nate Chapin wrote:
> On 2013/08/27 23:39:44, abarth wrote:
> >
>
https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
> > File Source/core/fetch/ResourceFetcher.cpp (left):
> > 
> >
>
https://codereview.chromium.org/22982011/diff/14001/Source/core/fetch/Resourc...
> > Source/core/fetch/ResourceFetcher.cpp:628: return ReturnCacheDataDontLoad;
> > On 2013/08/27 21:12:41, Nate Chapin wrote:
> > > This deletion is the only diff from what I attempted to land a few weeks
> ago.
> > 
> > We talked about this in person.  I think this line of code is correct.  The
> test
> > sets no-store but I think it's supposed to set no-cache to prevent caching.
> 
> +darin
> 
> The android test NavigationHistoryTest.testNavigateBackToNoncacheableLoginPage
> appears to be incorrectly setting

accidentally sent too soon, sorry:


 The android test NavigationHistoryTest.testNavigateBackToNoncacheableLoginPage
appears to be incorrectly setting cache control no-store instead of no-cache to
ensure a page isn't cacheable. As a result, once this patch lands and we get the
correct form resubmission behavior, that page is being evicted from the cache
and breaking blink's form resubmission case, where we tell the browser process
to never load from the network, and only serve from the cache.

The test appears to have been created just after I created this regression.

Does it seem reasonable to change the Cache-Control header to no-store?

[abarth-chromium, 2013-08-30 20:06:46]

On 2013/08/30 20:02:02, Nate Chapin wrote:
> Does it seem reasonable to change the Cache-Control header to no-store?

I presume you mean no-cache.

[Nate Chapin, 2013-08-30 20:11:36]

On 2013/08/30 20:06:46, abarth wrote:
> On 2013/08/30 20:02:02, Nate Chapin wrote:
> > Does it seem reasonable to change the Cache-Control header to no-store?
> 
> I presume you mean no-cache.

Yes. Sorry :(

[Nate Chapin, 2013-09-04 19:56:28]

On 2013/08/30 20:11:36, Nate Chapin wrote:
> On 2013/08/30 20:06:46, abarth wrote:
> > On 2013/08/30 20:02:02, Nate Chapin wrote:
> > > Does it seem reasonable to change the Cache-Control header to no-store?
> > 
> > I presume you mean no-cache.
> 
> Yes. Sorry :(

PTAL. This now exactly what was landed previously, and it will be ready to put
in the queue as soon as https://codereview.chromium.org/23464023/ lands.

[abarth-chromium, 2013-09-04 20:24:44]

lgtm

[commit-bot: I haz the power, 2013-09-04 20:48:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/22982011/37001

[commit-bot: I haz the power, 2013-09-05 01:09:44]

Change committed as 157253