Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 22982005: Fix overwriting order of object literal properties for MATERIALIZED_LITERALs (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix overwriting order of object literal properties for MATERIALIZED_LITERALs R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16179

Patch Set 1 #

Patch Set 2 : add crankshaft testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/ast.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/object-literal-overwrite.js View 1 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 4 months ago (2013-08-13 17:24:43 UTC) #1
Michael Starzinger
LGTM.
7 years, 4 months ago (2013-08-13 17:26:29 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-13 17:28:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16179.

Powered by Google App Engine
This is Rietveld 408576698