Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2298183005: Fix deps_updater.py to use 'origin/master' instead of 'master' (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix deps_updater.py to use 'origin/master' instead of 'master' BUG=643045 Committed: https://crrev.com/f6ebb91c6e76fd279286cf157a8e0c4fec998994 Cr-Commit-Position: refs/heads/master@{#415998}

Patch Set 1 #

Patch Set 2 : update_w3c_test_expectations.py #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (18 generated)
kojii
PTAL.
4 years, 3 months ago (2016-09-01 04:23:13 UTC) #7
qyearsley
On 2016/09/01 at 04:23:13, kojii wrote: > PTAL. LGTM Note, I think the reason for ...
4 years, 3 months ago (2016-09-01 16:37:44 UTC) #18
jsbell
lgtm 2
4 years, 3 months ago (2016-09-01 16:52:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298183005/40001
4 years, 3 months ago (2016-09-01 18:07:00 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 18:11:36 UTC) #22
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f6ebb91c6e76fd279286cf157a8e0c4fec998994 Cr-Commit-Position: refs/heads/master@{#415998}
4 years, 3 months ago (2016-09-01 18:14:48 UTC) #24
Dirk Pranke
4 years, 3 months ago (2016-09-01 19:41:12 UTC) #25
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698