|
|
Chromium Code Reviews
DescriptionFix deps_updater.py to use 'origin/master' instead of 'master'
BUG=643045
Committed: https://crrev.com/f6ebb91c6e76fd279286cf157a8e0c4fec998994
Cr-Commit-Position: refs/heads/master@{#415998}
Patch Set 1 #Patch Set 2 : update_w3c_test_expectations.py #Patch Set 3 : Rebase #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== deps_updater BUG= ========== to ========== deps_updater kojii@kojii1:~/src/chromium/src/third_party/WebKit$ update-w3c-deps css --auto-update --allow-local-commits ## Noting the current Chromium commit. ## Cloning https://chromium.googlesource.com/external/w3c/csswg-test.git into /usr/local/google/home/kojii/src/chromium/src/third_party/WebKit/csswg-test. ## Noting the revision we are importing. ## Cleaning out tests from LayoutTests/imported/csswg-test. ## Importing the tests. ## Deleting manual tests. ## Deleting any orphaned baselines. ## Deleting temp repo directory /usr/local/google/home/kojii/src/chromium/src/third_party/WebKit/csswg-test. # ret> 1 ## Committing changes. ## Done: changes imported and committed. ## Uploading change list. ## Gathering directory owners emails to CC. # ret> 128 # err> fatal: ambiguous argument 'master': unknown revision or path not in the working tree. # err> Use '--' to separate paths from revisions, like this: # err> 'git <command> [<revision>...] -- [<file>...]' BUG= ==========
Description was changed from ========== deps_updater kojii@kojii1:~/src/chromium/src/third_party/WebKit$ update-w3c-deps css --auto-update --allow-local-commits ## Noting the current Chromium commit. ## Cloning https://chromium.googlesource.com/external/w3c/csswg-test.git into /usr/local/google/home/kojii/src/chromium/src/third_party/WebKit/csswg-test. ## Noting the revision we are importing. ## Cleaning out tests from LayoutTests/imported/csswg-test. ## Importing the tests. ## Deleting manual tests. ## Deleting any orphaned baselines. ## Deleting temp repo directory /usr/local/google/home/kojii/src/chromium/src/third_party/WebKit/csswg-test. # ret> 1 ## Committing changes. ## Done: changes imported and committed. ## Uploading change list. ## Gathering directory owners emails to CC. # ret> 128 # err> fatal: ambiguous argument 'master': unknown revision or path not in the working tree. # err> Use '--' to separate paths from revisions, like this: # err> 'git <command> [<revision>...] -- [<file>...]' BUG= ========== to ========== Fix deps_updater.py requiring 'master' branch BUG=643045 ==========
Description was changed from ========== Fix deps_updater.py requiring 'master' branch BUG=643045 ========== to ========== Fix deps_updater.py to use 'origin/master' instead of 'master' BUG=643045 ==========
kojii@chromium.org changed reviewers: + dpranke@chromium.org, jsbell@chromium.org, qyearsley@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/01 at 04:23:13, kojii wrote: > PTAL. LGTM Note, I think the reason for this was that Dre (the intern who wrote this) and I both only tested this locally where we both have a local branch called "master". (Note on potentially follow-up: This could be extracted to a helper method, maybe in the Git class. In the Git class right now there's a method called affected_files (https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...) and git.affected_files('HEAD') will list affected files of the last commit.)
lgtm 2
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix deps_updater.py to use 'origin/master' instead of 'master' BUG=643045 ========== to ========== Fix deps_updater.py to use 'origin/master' instead of 'master' BUG=643045 Committed: https://crrev.com/f6ebb91c6e76fd279286cf157a8e0c4fec998994 Cr-Commit-Position: refs/heads/master@{#415998} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f6ebb91c6e76fd279286cf157a8e0c4fec998994 Cr-Commit-Position: refs/heads/master@{#415998}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
