Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: net/dns/host_cache_unittest.cc

Issue 2298173002: Implement host-based deletion for the hostname resolution cache. (Closed)
Patch Set: Take TimeTicks::Now() out of the loop Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/host_cache.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_cache_unittest.cc
diff --git a/net/dns/host_cache_unittest.cc b/net/dns/host_cache_unittest.cc
index 00ec78258c00991efa4af103aba5565608924129..30efd2d3eb9f751cac471005f9789a6e4bbac7f1 100644
--- a/net/dns/host_cache_unittest.cc
+++ b/net/dns/host_cache_unittest.cc
@@ -4,6 +4,10 @@
#include "net/dns/host_cache.h"
+#include <string>
+
+#include "base/bind.h"
+#include "base/callback.h"
#include "base/format_macros.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
@@ -22,6 +26,10 @@ HostCache::Key Key(const std::string& hostname) {
return HostCache::Key(hostname, ADDRESS_FAMILY_UNSPECIFIED, 0);
}
+bool FoobarIndexIsOdd(const std::string& foobarx_com) {
+ return (foobarx_com[6] - '0') % 2 == 1;
+}
+
} // namespace
TEST(HostCacheTest, Basic) {
@@ -296,6 +304,40 @@ TEST(HostCacheTest, Clear) {
EXPECT_EQ(0u, cache.size());
}
+TEST(HostCacheTest, ClearForHosts) {
+ const base::TimeDelta kTTL = base::TimeDelta::FromSeconds(10);
+
+ HostCache cache(kMaxCacheEntries);
+
+ // Set t=0.
+ base::TimeTicks now;
+
+ HostCache::Entry entry = HostCache::Entry(OK, AddressList());
+
+ EXPECT_EQ(0u, cache.size());
+
+ // Add several entries.
+ cache.Set(Key("foobar1.com"), entry, now, kTTL);
+ cache.Set(Key("foobar2.com"), entry, now, kTTL);
+ cache.Set(Key("foobar3.com"), entry, now, kTTL);
+ cache.Set(Key("foobar4.com"), entry, now, kTTL);
+ cache.Set(Key("foobar5.com"), entry, now, kTTL);
+
+ EXPECT_EQ(5u, cache.size());
+
+ // Clear the hosts matching a certain predicate, such as the number being odd.
+ cache.ClearForHosts(base::Bind(&FoobarIndexIsOdd));
+
+ EXPECT_EQ(2u, cache.size());
+ EXPECT_TRUE(cache.Lookup(Key("foobar2.com"), now));
+ EXPECT_TRUE(cache.Lookup(Key("foobar4.com"), now));
+
+ // Passing null callback will delete all hosts.
+ cache.ClearForHosts(base::Callback<bool(const std::string&)>());
+
+ EXPECT_EQ(0u, cache.size());
+}
+
// Try to add too many entries to cache; it should evict the one with the oldest
// expiration time.
TEST(HostCacheTest, Evict) {
« no previous file with comments | « net/dns/host_cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698