Move CPDF_Type3Cache and CPDF_Type3Glyphs to their own files

Move CPDF_Type3Cache and CPDF_Type3Glyphs to their own files

Committed: https://pdfium.googlesource.com/pdfium/+/eadff195ea8a8e0d1f400bd8910873ce8e38635f

[npm, 2016-09-01 18:59:27]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:59:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-09-01 18:59:46]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[dsinclair, 2016-09-01 19:28:35]

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
File core/fpdfapi/fpdf_render/cpdf_type3cache.h (right):

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3cache.h:27: FX_FLOAT retinaScaleY = 1.0f);
Can we get rid of the default params while we're doing this?

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
File core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp (right):

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:22: FX_FLOAT min_distance =
1000000.0f * 1.0f;
.... Can we just remove the * 1.0f?

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:25: FX_FLOAT distance =
(FX_FLOAT)FXSYS_fabs(pos - (FX_FLOAT)blues[i]);
FXSYS_fabs returns FX_FLOAT so the outer cast isn't needed. static_cast for the
inner.

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:33: }
nit {}'s

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:41: void
CPDF_Type3Glyphs::AdjustBlue(FX_FLOAT top,
nit: blank line before

[commit-bot: I haz the power, 2016-09-01 19:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:33:55]

Dry run: This issue passed the CQ dry run.

[npm, 2016-09-01 19:37:50]

PTAL

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
File core/fpdfapi/fpdf_render/cpdf_type3cache.h (right):

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3cache.h:27: FX_FLOAT retinaScaleY = 1.0f);
On 2016/09/01 19:28:35, dsinclair wrote:
> Can we get rid of the default params while we're doing this?

Done.

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
File core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp (right):

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:22: FX_FLOAT min_distance =
1000000.0f * 1.0f;
On 2016/09/01 19:28:35, dsinclair wrote:
> .... Can we just remove the * 1.0f?

Done.

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:25: FX_FLOAT distance =
(FX_FLOAT)FXSYS_fabs(pos - (FX_FLOAT)blues[i]);
On 2016/09/01 19:28:35, dsinclair wrote:
> FXSYS_fabs returns FX_FLOAT so the outer cast isn't needed. static_cast for
the
> inner.

Done.

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:33: }
On 2016/09/01 19:28:35, dsinclair wrote:
> nit {}'s

Done.

https://codereview.chromium.org/2298163004/diff/1/core/fpdfapi/fpdf_render/cp...
core/fpdfapi/fpdf_render/cpdf_type3glyphs.cpp:41: void
CPDF_Type3Glyphs::AdjustBlue(FX_FLOAT top,
On 2016/09/01 19:28:35, dsinclair wrote:
> nit: blank line before

I think I completely forgot to nit-check this one, sorry

[npm, 2016-09-01 19:39:42]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 19:39:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-01 19:40:37]

lgtm

[commit-bot: I haz the power, 2016-09-01 20:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:17:37]

Dry run: This issue passed the CQ dry run.

[npm, 2016-09-01 20:21:15]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:21:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:21:38]

Description was changed from

==========
Move CPDF_Type3Cache and CPDF_Type3Glyphs to their own files
==========

to

==========
Move CPDF_Type3Cache and CPDF_Type3Glyphs to their own files

Committed:
https://pdfium.googlesource.com/pdfium/+/eadff195ea8a8e0d1f400bd8910873ce8e38...
==========

[commit-bot: I haz the power, 2016-09-01 20:21:40]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/eadff195ea8a8e0d1f400bd8910873ce8e38...