Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: ui/base/ime/input_method_win.cc

Issue 2298123003: Using input language instead of the application locale to determine the Omnibox's text input type o… (Closed)
Patch Set: fix compiling errors in mus. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_win.h ('k') | ui/base/ime/mock_input_method.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_win.cc
diff --git a/ui/base/ime/input_method_win.cc b/ui/base/ime/input_method_win.cc
index 8456b0cbde6f2d4954f3a1d24be3fedd336bea26..8975069a3134bcc92ab411e3cdeed68ea7d57bdf 100644
--- a/ui/base/ime/input_method_win.cc
+++ b/ui/base/ime/input_method_win.cc
@@ -267,12 +267,18 @@ void InputMethodWin::CancelComposition(const TextInputClient* client) {
}
void InputMethodWin::OnInputLocaleChanged() {
- // Note: OnInputLocaleChanged() is for crbug.com/168971.
+ // Note: OnInputLocaleChanged() is for capturing the input language which can
+ // be used to determine the appropriate TextInputType for Omnibox.
+ // See crbug.com/344834.
+ // Currently OnInputLocaleChanged() on Windows relies on WM_INPUTLANGCHANGED,
+ // which is known to be incompatible with TSF.
+ // TODO(shuchen): Use ITfLanguageProfileNotifySink instead.
OnInputMethodChanged();
+ imm32_manager_.SetInputLanguage();
}
-std::string InputMethodWin::GetInputLocale() {
- return imm32_manager_.GetInputLanguageName();
+bool InputMethodWin::IsInputLocaleCJK() const {
+ return imm32_manager_.IsInputLanguageCJK();
}
bool InputMethodWin::IsCandidatePopupOpen() const {
« no previous file with comments | « ui/base/ime/input_method_win.h ('k') | ui/base/ime/mock_input_method.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698