tools/telemetry/telemetry/page/csv_page_measurement_results.py - Issue 22981005: [telemetry] Move Results options out of PageTest/Measurement into their own module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/csv_page_measurement_results.py

Issue 22981005: [telemetry] Move Results options out of PageTest/Measurement into their own module. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge and lint. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/csv_page_measurement_results.py

diff --git a/tools/telemetry/telemetry/page/csv_page_measurement_results.py b/tools/telemetry/telemetry/page/csv_page_measurement_results.py

index 9dbf6fb7e25f6caf960c7c9f04a3333fae776e18..3770021051e6b091b13c3df328c0df5323c08521 100644

--- a/tools/telemetry/telemetry/page/csv_page_measurement_results.py

+++ b/tools/telemetry/telemetry/page/csv_page_measurement_results.py

@@ -7,10 +7,9 @@ from telemetry.page import page_measurement_results

class CsvPageMeasurementResults(

page_measurement_results.PageMeasurementResults):

- def __init__(self, output_stream=None, output_after_every_page=None):

+ def __init__(self, output_stream, output_after_every_page=None):

super(CsvPageMeasurementResults, self).__init__()

- if output_stream:

- self._results_writer = csv.writer(output_stream)

+ self._results_writer = csv.writer(output_stream)

self._did_output_header = False

self._header_names_written_to_writer = None

self._output_after_every_page = output_after_every_page

« no previous file with comments | « tools/telemetry/telemetry/core/browser_options.py ('k') | tools/telemetry/telemetry/page/gtest_test_results.py » ('j') | no next file with comments »