Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2298093002: Top Hosts computation should not use redirected urls and subframe urls (Closed)

Created:
4 years, 3 months ago by Raj
Modified:
4 years, 3 months ago
Reviewers:
sky, sdefresne
CC:
chromium-reviews, bengr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Top Hosts computation should not use redirected urls and subframe urls BUG=614188 Committed: https://crrev.com/276df9be47cf9aec1dc7501afef203e1e5b2b052 Cr-Commit-Position: refs/heads/master@{#416658}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -20 lines) Patch
M components/history/core/browser/history_backend_unittest.cc View 7 chunks +68 lines, -19 lines 0 comments Download
M components/history/core/browser/history_database.cc View 1 chunk +12 lines, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
Raj
sky: ptal
4 years, 3 months ago (2016-08-31 05:56:30 UTC) #2
sky
https://codereview.chromium.org/2298093002/diff/1/components/history/core/browser/history_database.cc File components/history/core/browser/history_database.cc (right): https://codereview.chromium.org/2298093002/diff/1/components/history/core/browser/history_database.cc#newcode196 components/history/core/browser/history_database.cc:196: TopHostsList HistoryDatabase::TopHosts(size_t num_hosts) { I'm not familiar with this ...
4 years, 3 months ago (2016-08-31 16:29:47 UTC) #3
Raj
sdefresne: ptal Thanks sky
4 years, 3 months ago (2016-08-31 16:34:50 UTC) #5
sdefresne
lgtm
4 years, 3 months ago (2016-09-06 16:14:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298093002/1
4 years, 3 months ago (2016-09-06 16:18:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 17:51:36 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 17:53:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/276df9be47cf9aec1dc7501afef203e1e5b2b052
Cr-Commit-Position: refs/heads/master@{#416658}

Powered by Google App Engine
This is Rietveld 408576698