Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4635)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 2298073003: Better access to offline login flow from user pods (Closed)
Patch Set: Cleaned up for review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 7bd148a67e50234ad152775908d318c00d3f0afa..78d0af0171261a6593cbcc5d3b9a0f7d03782771 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -831,7 +831,6 @@ void SigninScreenHandler::SetupAndShowOfflineMessage(
network_error_model_->AllowGuestSignin(guest_signin_allowed);
const bool offline_login_allowed =
- IsOfflineLoginAllowed() &&
IsSigninScreenError(network_error_model_->GetErrorState()) &&
network_error_model_->GetErrorState() !=
NetworkError::ERROR_STATE_AUTH_EXT_TIMEOUT;
@@ -1108,7 +1107,7 @@ void SigninScreenHandler::HandleLaunchPublicSession(
}
void SigninScreenHandler::HandleOfflineLogin(const base::ListValue* args) {
- if (!delegate_ || delegate_->IsShowUsers()) {
+ if (!delegate_) {
NOTREACHED();
return;
}
@@ -1474,17 +1473,6 @@ bool SigninScreenHandler::IsGuestSigninAllowed() const {
return allow_guest;
}
-bool SigninScreenHandler::IsOfflineLoginAllowed() const {
- CrosSettings* cros_settings = CrosSettings::Get();
- if (!cros_settings)
- return false;
-
- // Offline login is allowed only when user pods are hidden.
- bool show_pods;
- cros_settings->GetBoolean(kAccountsPrefShowUserNamesOnSignIn, &show_pods);
- return !show_pods;
-}
-
void SigninScreenHandler::OnShowAddUser() {
is_account_picker_showing_first_time_ = false;
gaia_screen_handler_->ShowGaiaAsync();
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698