Add more safety checks.

appengine/swarming/server/task_result.py

 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Task execution result models.
 
 This module doesn't do the scheduling itself. It only describes the entities to
 store tasks results.
 
 - TaskResultSummary represents the overall result for the TaskRequest taking in
@@ skipping 618 matching lines @@
     elif self.state != State.BOT_DIED:
       # With BOT_DIED, it can be either ways.
       if self.duration is not None:
         raise datastore_errors.BadValueError(
             'duration and exit_code must not be set with state %s' %
             State.to_string(self.state))
 
     if self.deduped_from:
       if self.state != State.COMPLETED:
         raise datastore_errors.BadValueError(
-            'state must be COMPLETED on deduped task')
+            'state(%d) must be COMPLETED on deduped task %s' %
+            (self.state, self.deduped_from))
       if self.failure:
         raise datastore_errors.BadValueError(
-            'failure can\'t be True on deduped task')
+            'failure can\'t be True on deduped task %s' % self.deduped_from)
 
     self.children_task_ids = sorted(
         set(self.children_task_ids), key=lambda x: int(x, 16))
 
   @classmethod
   def _properties_fixed(cls):
     """Returns all properties with their member name, excluding computed
     properties.
     """
     return [
@@ skipping 549 matching lines @@
   if tags:
     # Add TaskResultSummary indexes if desired.
     if sort != 'created_ts':
       raise ValueError(
           'Add needed indexes for sort:%s and tags if desired' % sort)
     tags_filter = TaskResultSummary.tags == tags[0]
     for tag in tags[1:]:
       tags_filter = ndb.AND(tags_filter, TaskResultSummary.tags == tag)
     query = query.filter(tags_filter)
   return _filter_query(TaskResultSummary, query, start, end, sort, state)