Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2298043002: Revert "Flush AST results for source outside of the analysis roots." (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Flush AST results for source outside of the analysis roots." This reverts commit b1153095310c76ddbf8da1fcd17cdf360c0fc526. Revert "Use FlushTargetFilter to pre-filter targets before checking their results." This reverts commit 2e24662c066e7340f2f60e29fc2f795fd65f6bba. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f8f4228728297ac5c7b586c7b49c0bfa44cd80a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -55 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 4 chunks +0 lines, -26 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 4 chunks +13 lines, -22 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-08-31 01:21:42 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-08-31 02:53:17 UTC) #2
scheglov
4 years, 3 months ago (2016-08-31 02:55:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8f4228728297ac5c7b586c7b49c0bfa44cd80a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698