Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2298033002: [ABANDONED] Revert of Add new filter repaint test for turbulence, rebaseline existing test (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
pdr., Stephen White, wkorman
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add new filter repaint test for turbulence, rebaseline existing test (patchset #4 id:60001 of https://codereview.chromium.org/2294633002/ ) Reason for revert: css3/filters/filter-repaint-turbulence.html is failing on Linux (dbg), WebKit Mac10.11 (dbg) and WebKit Win7 (dbg). https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/9089 Original issue's description: > Add new filter repaint test for turbulence, rebaseline existing test > > This patch adds a new (currently failing) filter repaint test to show > how we improperly repaint turbulence filters. In addition, the existing > test for 640264 has been unskipped and rebaselined with a failing > result. These two changes should help catch progressions in the future. > > BUG=598051, 640264 > > Committed: https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020 > Cr-Commit-Position: refs/heads/master@{#415363} TBR=senorblanco@chromium.org,wkorman@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598051, 640264

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
yhirano
Created Revert of Add new filter repaint test for turbulence, rebaseline existing test
4 years, 3 months ago (2016-08-31 01:01:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298033002/1
4 years, 3 months ago (2016-08-31 01:02:14 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:02:55 UTC) #5
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:558
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with
conflicts.
  U third_party/WebKit/LayoutTests/TestExpectations

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
0185ec7a23fb3a233b79321049e24b3936da168a..95c2df5acc98189c57eea051287f3812790d38d3
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -558,8 +558,8 @@
 
 crbug.com/617785 fast/borders/block-mask-overlay-image-outset.html [ Skip ]
 
-crbug.com/640264 css3/filters/effect-reference-hidpi.html [ NeedsRebaseline ]
-crbug.com/640264 css3/filters/filter-repaint-turbulence.html [ NeedsRebaseline
]
+# Some SVG tests fail due to incorrect visual rects.
+crbug.com/598051 css3/filters/effect-reference-hidpi.html [ Skip ]
 
 # Either "combo" or split should run:
http://testthewebforward.org/docs/css-naming.html
 crbug.com/410320
imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001.html
[ Skip ]

Powered by Google App Engine
This is Rietveld 408576698