Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2298013004: Try to fix clang plugin tests after https://codereview.chromium.org/2270433002/ (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, hans
CC:
chromium-reviews, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to fix clang plugin tests after https://codereview.chromium.org/2270433002/ BUG=none TBR=thestig@chromium.org NOTRY=true Committed: https://crrev.com/4d4c5fbd5bec361b597abfbaf759fb51acb0347c Cr-Commit-Position: refs/heads/master@{#415755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/clang/plugins/tests/test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
4 years, 3 months ago (2016-08-31 21:14:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298013004/1
4 years, 3 months ago (2016-08-31 21:15:47 UTC) #4
hans
It's unfortunate that it's so painful to run these tests locally that we never do ...
4 years, 3 months ago (2016-08-31 21:20:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 21:20:53 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4d4c5fbd5bec361b597abfbaf759fb51acb0347c Cr-Commit-Position: refs/heads/master@{#415755}
4 years, 3 months ago (2016-08-31 21:22:26 UTC) #10
Lei Zhang
4 years, 3 months ago (2016-08-31 21:37:44 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698